[Zope-Coders] Re: [CMF-checkins] CVS: CMF/CMFWiki - CMFWikiPage.py:1.28

[Florent Guillaume]

Chris McDonough  <chrism@zope.com> wrote:
> --- CMF/CMFWiki/CMFWikiPage.py:1.27	Sat Aug  3 23:51:56 2002
> +++ CMF/CMFWiki/CMFWikiPage.py	Thu Oct 17 15:38:37 2002
> @@ -467,11 +467,11 @@
>          get_transaction().note(log)
>          self.last_log = log
>          user = getSecurityManager().getUser()
> -        username = user.getUserName()
> -        if username == 'Anonymous User':
> +        if user.getUserName() == 'Anonymous User':
>              username = ''

I know this isn't really Chris's code, but anyway:

Ideally, should this kind of check be done on the name or id? I'd have
said id, but maybe I'm wrong.

Shouldn't we really compare to the SpecialUsers.nobody user?

Florent
-- 
Florent Guillaume, Nuxeo (Paris, France)
+33 1 40 33 79 87  http://nuxeo.com  mailto:fg@nuxeo.com