[Zope-Coders] Re: [Zope-Checkins] CVS: Zope/lib/python/ZPublisher - Converters.py:1.14.8.2

[Chris Withers]

Casey Duncan wrote:
> BTW, I have reverted the change to PropertyManager.py on the HEAD, 2.6 and 2.5 
> branch because it breaks any property sheet with an integer property.

damn :-(

> As a note for the future, running unit tests is not enough,. Please do 
> "functional" testing as well. IOW after making a change like this, see if you 
> can break it through the ZMI. Some quick playing around in the ZMI would 
> easily identify this bug and save us time and hassle.

I did, it just so happens that the propertysheets I was playing with had no 
integers on them :-(

> And if you really feel motivated, and can break code without the tests 
> noticing it, fix the tests.

I usually do, but in this case there was a customer literally sitting at my left 
elbow wanting their work done, not Zope properly tested once their problem had 
been fixed :-(

Chris