[CMF-checkins] CVS: CMF/CMFCore - MembershipTool.py:1.27

Shane Hathaway shane@zope.com
Mon, 14 Oct 2002 16:20:08 -0400


Chris McDonough wrote:
> Update of /cvs-repository/CMF/CMFCore
> In directory cvs.zope.org:/tmp/cvs-serv7531
> 
> Modified Files:
> 	MembershipTool.py 
> Log Message:
> Snarky comment.
> 
> 
> === CMF/CMFCore/MembershipTool.py 1.26 => 1.27 ===
> --- CMF/CMFCore/MembershipTool.py:1.26	Sat Aug  3 22:31:30 2002
> +++ CMF/CMFCore/MembershipTool.py	Mon Oct 14 15:47:35 2002
> @@ -404,6 +404,9 @@
>              raise "Can't add Member", "No supported UserSources"
>  
>          if properties is not None:
> +            # note that the below seems really silly.  We *are* the
> +            # portal_membership tool, aren't we?  Is there a reason
> +            # for this?  Acqusition?  How about a comment?  - chrism
>              membership = getToolByName(self, 'portal_membership')
>              member = membership.getMemberById(id)
>              member.setMemberProperties(properties)

This little bit of code used to be in the registration tool.  It was 
apparently copied verbatim.  You can safely simplify it. :-)

Shane