[Grok-dev] Re: big grok refactoring

Jan-Wijbrand Kolman janwijbrand at gmail.com
Thu Feb 8 05:39:59 EST 2007

> > Cool. Can you also write a test in grok/tests/grokker that tests this?
> > Then I'll be happy to apply the patch.
> Also, could you add a comment somewhere close to your modifications
> (perhaps in registerGrokker()) that explains why we're using a
> dictionary and the classes as keys... It might not be obvious to
> somebody reading the code at a later point.

Here's the patch + test.

The test looks rather involved to me, but I couldn't come up with
simpler setup to expose the problem and the test the solution.

I hope you can apply it like this, or suggest improvements.

kind regards,

Jan-Wijbrand Kolman
-------------- next part --------------
A non-text attachment was scrubbed...
Name: onlyonce.patch
Type: text/x-patch
Size: 6111 bytes
Desc: not available
Url : http://mail.zope.org/pipermail/grok-dev/attachments/20070208/ac2a7a3a/onlyonce.bin

More information about the Grok-dev mailing list