[Grok-dev] Re: Proposal to merge ksmith_mcweekly-layers branch

Kevin Smith kevin at mcweekly.com
Fri Sep 14 20:19:20 EDT 2007


Wow, alot *has* changed. Yes, please review, a new branch has been 
created based on grok 0.11 trunk, at ksmith_mcweekly-layers-011. Ftests 
are in view/layers.py


Kevin

Martijn Faassen wrote:
> Martijn Faassen wrote:
>> Kevin Smith wrote:
>>> Unless there are any objections, the skins and layers branch is 
>>> ready for merge.
>>
>> +1. It'd be nice if someone reviewed the branch before merge, but if 
>> not, we'll review it after merge.
>
> I just tried to review this branch but because it's so old, too much 
> has changed in Grok since then me to make sense of what is layer 
> specific.
>
> If you *want* a review before you merge, please update your branch 
> with a recent trunk. But don't let it stop you if that takes too much 
> time; just merge the branch with the trunk otherwise and make sure you 
> update CHANGES.txt. We will review the work afterwards. I know we had 
> plenty of discussion at the time anyway.
>
> Regards,
>
> Martijn
>
> _______________________________________________
> Grok-dev mailing list
> Grok-dev at zope.org
> http://mail.zope.org/mailman/listinfo/grok-dev
>


More information about the Grok-dev mailing list