[Grok-dev] five.grok - what changed to break this?

[sylvain at infrae.com]

> sylvain at infrae.com wrote:
> cd

  Hello,


>>   Like in Grok you don't include yourself in your meta.zcml a dependency
>> to grokcore.view, here neither. five.grok include for your only usefull
>> parts of grokcore.view, and redefines others.
>>
>>   You should just remove that, and have in your zcml:
>>
>>   <include package="five.grok" file="meta.zcml" />
>>   <include package="five.grok" />
>>
>>   And nothing else.
>
> I'm not sure I understand you. The example.dexterity meta.zcml has:
>
> <configure xmlns="http://namespaces.zope.org/zope">
>
>    <include package="plone.dexterity" file="meta.zcml" />
>
> </configure>
>
> In plone.dexterity, we have:
>
> <configure
>      xmlns="http://namespaces.zope.org/zope"
>      xmlns:grok="http://namespaces.zope.org/grok"
>      i18n_domain="plone.dexterity">
>
>      <!-- Include ZCML directive from plone.behavior -->
>      <include package="plone.behavior" file="meta.zcml" />
>
>      <!-- Depend on five.grok - includes grokcore.component & friends -->
>      <include package="five.grok" file="meta.zcml" />
>
>      <!-- Depend on plone.supermodel's grokkers -->
>      <include package="plone.supermodel" file="meta.zcml" />
>
>      <!-- Register our own grokkers -->
>      <grok:grok package=".directives" />
>
> </configure>
>

  I think that's ok,

> And finally, in five.grok:
>
> <configure
>      xmlns="http://namespaces.zope.org/zope"
>      xmlns:meta="http://namespaces.zope.org/meta"
>      xmlns:grok="http://namespaces.zope.org/grok">
>
>    <include package="grokcore.component" file="meta.zcml" />
>    <include package="grokcore.security" file="meta.zcml" />
>
>    <!-- Load minimal support of grokcore.view, views + templates  -->
>    <include package="grokcore.view" file="meta-minimal.zcml" />
>    <include package="grokcore.formlib" file="meta.zcml" />
>
>    <!-- Include skin support as well -->
>    <grok:grok package="grokcore.view.meta.skin" />
>
>    <grok:grok package=".meta" />
>
> </configure>
>
>
> Are you saying the five.grok meta.zcml is broken?
>

   Well, I use it as well and don't have that problem, so this should be
ok. I am not 100% fond of having a meta-minimal.cfg, but there is no
others ways to split meta.py of grokcore.view and let other
applications (grok, five.grok) use only a part of it.


> /me slaps head
>
> No, hold on a minute; this may be because of buildout.eggtractor
> including the grokcore.view meta.zcml for me because I've got it as a
> develop egg. D'oh! I'll try to remove that and see what happens.
>

  Ha, I don't use such scripts, because I still have a lot of unused
extension in my src that I don't always included evrything. By the way,
you have a release of grokcore.view which should be ok, you don't need
anymore to have it as a development egg, unless you plan to make change
on it; Same goes for grokcore.component, security and formlib.

   Best regards,

   Sylvain,