[Zodb-checkins] CVS: Packages/bsddb3Storage - BerkeleyBase.py:1.8

bwarsaw@cvs.baymountain.com bwarsaw@cvs.baymountain.com
Tue, 17 Jul 2001 17:37:23 -0400


Update of /cvs-repository/Packages/bsddb3Storage/bsddb3Storage
In directory cvs.baymountain.com:/tmp/cvs-serv17114

Modified Files:
	BerkeleyBase.py 
Log Message:
_abort(): Must call _closelog() otherwise the commit log file is left
in a bogus state.  Without this, after a transaction abort
(i.e. through an exception), nothing can modify the database.



--- Updated File BerkeleyBase.py in package Packages/bsddb3Storage --
--- BerkeleyBase.py	9 Jul 2001 19:14:14 -0000	1.7
+++ BerkeleyBase.py	17 Jul 2001 21:37:23 -0000	1.8
@@ -181,16 +181,8 @@
     def _abort(self):
         """Called from BaseStorage.tpc_abort(), this aborts the underlying
         BSDDB transaction.
-        
-        tid is the transaction id
-        user is the transaction user
-        desc is the transaction description
-        ext is the transaction extension
-
-        These are all ignored.
         """
-        # BAW: this appears to be broken.  Look in BaseStorage.tpc_abort();
-        # _abort() is never called with any arguments. :/
+        self._closelog()
         self._transaction.abort()
 
     def _clear_temp(self):



--- Updated File BerkeleyBase.py in package Packages/bsddb3Storage --
--- BerkeleyBase.py	9 Jul 2001 19:14:14 -0000	1.7
+++ BerkeleyBase.py	17 Jul 2001 21:37:23 -0000	1.8
@@ -181,16 +181,8 @@
     def _abort(self):
         """Called from BaseStorage.tpc_abort(), this aborts the underlying
         BSDDB transaction.
-        
-        tid is the transaction id
-        user is the transaction user
-        desc is the transaction description
-        ext is the transaction extension
-
-        These are all ignored.
         """
-        # BAW: this appears to be broken.  Look in BaseStorage.tpc_abort();
-        # _abort() is never called with any arguments. :/
+        self._closelog()
         self._transaction.abort()
 
     def _clear_temp(self):