[Zodb-checkins] CVS: Zope/lib/python/ZODB - Connection.py:1.123

[Jim Fulton]

Tim Peters wrote:
> [JimF]
> 
>>Modified Files:
>>	Connection.py
>>Log Message:
>>Re-commented an _p_oid assertion that was causing multiple failures
>>on the Zope 2 head. While I can appreciate the desire to unserstand
>>why register would be called by an object that has no _p_oid,
>>such questions should be answered in a sandbox, without breaking the
>>head.
> 
> 
> What did you do that turned up failures? 

I ran the zope 2 head tests:

   python2.3 test.py

 > Jeremy tried all the ZODB tests
> without provoking a failure, so didn't expect he was breaking anything. 

That was before he uncommented the assertion.

 > If
> it's intended that registering objects without an oid is OK, then there are
> still bugs (of omission) in the docs and the ZODB test suite.

I wasn't suggesting that the issue shouldn't be investigated,
but breaking tests on the head isn't the way to do it. :)

Jim

-- 
Jim Fulton           mailto:jim at zope.com       Python Powered!
CTO                  (540) 361-1714            http://www.python.org
Zope Corporation     http://www.zope.com       http://www.zope.org