[Zope-Checkins] CVS: Zope/lib/python/Zope/App - startup.py:1.8.2.5

Chris McDonough chrism at plope.com
Sun May 23 01:53:45 EDT 2004


Update of /cvs-repository/Zope/lib/python/Zope/App
In directory cvs.zope.org:/tmp/cvs-serv11224/lib/python/Zope/App

Modified Files:
      Tag: Zope-2_7-branch
	startup.py 
Log Message:
Collector 789:  Zope's transaction behavior flawed.

Historically, errors that made it up to the publisher have run outside the
context of a transaction.  This has caused problems for applications which
expect to be able to write to the database (if only temporarily, before
transaction.abort() is eventually called).

With this patch, we allow the error to execute in the same transaction as
the "main" request, and abort only after the error has executed.


=== Zope/lib/python/Zope/App/startup.py 1.8.2.4 => 1.8.2.5 ===
--- Zope/lib/python/Zope/App/startup.py:1.8.2.4	Mon Mar 22 11:25:47 2004
+++ Zope/lib/python/Zope/App/startup.py	Sun May 23 01:53:44 2004
@@ -179,8 +179,6 @@
             published=app.__bobo_traverse__(REQUEST).__of__(
                 RequestContainer(REQUEST))
 
-        get_transaction().begin() # Just to be sure.
-
         published=getattr(published, 'im_self', published)
         while 1:
             f=getattr(published, 'raise_standardErrorMessage', None)




More information about the Zope-Checkins mailing list