[Zope-Checkins] SVN: Zope/trunk/src/ - don't raise string exceptions

Yvo Schubbe y.2010 at wcm-solutions.de
Tue Jul 27 07:13:40 EDT 2010


Log message for revision 115117:
  - don't raise string exceptions

Changed:
  U   Zope/trunk/src/OFS/userfolder.py
  U   Zope/trunk/src/Products/SiteErrorLog/SiteErrorLog.py

-=-
Modified: Zope/trunk/src/OFS/userfolder.py
===================================================================
--- Zope/trunk/src/OFS/userfolder.py	2010-07-27 11:13:00 UTC (rev 115116)
+++ Zope/trunk/src/OFS/userfolder.py	2010-07-27 11:13:40 UTC (rev 115117)
@@ -288,10 +288,10 @@
 
     def _setId(self, id):
         if id != self.id:
-            raise MessageDialog(
+            raise ValueError(MessageDialog(
                 title='Invalid Id',
                 message='Cannot change the id of a UserFolder',
-                action='./manage_main')
+                action='./manage_main'))
 
 
 class UserFolder(accesscontrol_userfolder.UserFolder, BasicUserFolder):

Modified: Zope/trunk/src/Products/SiteErrorLog/SiteErrorLog.py
===================================================================
--- Zope/trunk/src/Products/SiteErrorLog/SiteErrorLog.py	2010-07-27 11:13:00 UTC (rev 115116)
+++ Zope/trunk/src/Products/SiteErrorLog/SiteErrorLog.py	2010-07-27 11:13:40 UTC (rev 115117)
@@ -103,10 +103,10 @@
 
     def _setId(self, id):
         if id != self.id:
-            raise MessageDialog(
+            raise ValueError(MessageDialog(
                 title='Invalid Id',
                 message='Cannot change the id of a SiteErrorLog',
-                action ='./manage_main',)
+                action='./manage_main'))
 
     def _getLog(self):
         """Returns the log for this object.



More information about the Zope-Checkins mailing list