[Zope-CMF] Proposed default workflow policy change

[Jeff Sasmor]

>From looking at CVS I see this changed 3/27. Must have been a few days after
I downloaded
the version I was working on thru all of April. Argh. It used to look like:

        allow_review = _checkPermission('Review portal content', ob)
        allow_request = _checkPermission('Request review', ob)
        if not allow_review and not allow_request:
            return default

        if name == 'review_state':
            return self.getReviewStateOf(ob)


now it's

       # Treat this as public.
        if name == 'review_state':
            return self.getReviewStateOf(ob)

        allow_review = _checkPermission('Review portal content', ob)
        allow_request = _checkPermission('Request review', ob)
        if not allow_review and not allow_request:
            return default

Great!
I guess I need to do CVS updates more often.....
jeff


----- Original Message -----
From: "Tres Seaver" <tseaver@novacoxmail.com>
To: "Jeff Sasmor" <jeff@janix.com>
Cc: <zope-cmf@zope.org>
Sent: Wednesday, May 02, 2001 7:50 PM
Subject: Re: [Zope-CMF] Proposed default workflow policy change


> Jeff Sasmor wrote:
> >
> > I disagree, too.
> >
> > What would be nice would be to change the default workflow
> > so that **Determining** the state of an object would be
> > publicly accessible.  Right now AFAIK that only is possible
> > for the owner of a CMF content type (or a manager or a
> > reviewer).
> >
> > If two lines in CMFDefault/DefaultWorkflow were changed
> > (lines 287 and 288)
> >      allow_review = _checkPermission('Review portal content', ob)
> >      allow_request = _checkPermission('Request review', ob)
>
> Not on the CVS trunk:  the lines before that:
>
>     # Treat this as public.
>     if name == 'review_state':
>         return self.getReviewStateOf(ob)
>
> return the 'review_state' information regardless of roles.
> The permission checks guard the rest of the information
> ('review_history', in this case) which is quite appropriate.
>
> Tres.
> --
> ===============================================================
> Tres Seaver                                tseaver@digicool.com
> Digital Creations     "Zope Dealers"       http://www.zope.org
>