[Zope-CMF] Toggle skins - Recipe Updated

Tres Seaver tseaver@zope.com
23 Aug 2002 18:04:04 -0400


On Fri, 2002-08-23 at 13:36, Carl Rendell wrote:
> 
> On Friday, August 23, 2002, at 09:55  AM, Tres Seaver wrote:
> 
> > On Fri, 2002-08-23 at 12:25, Carl Rendell wrote:
> >> Just an fyi.
> >>
> >> Alan has check changes to CMFCore.Skinnable (version 1.7) into CVS,
> >> and the recipe on ZopeLabs has been changed to reflect the new
> >> method - changeskin() -
> >>
> >> http://www.zopelabs.com/cookbook/1028172355
> >>
> >> BTW... Is there going to be a CMF 1.3.1 release? It's been asked
> >> before, and it would seem that quite a few changes have been going
> >> into CVS post release. The challenge might be picking a point at
> >> which to make the release.
> >
> > I would probably avoid doing a 1.3.1 release at the moment;  the one
> > bugfix which might warrant a release is not for a "glaring" problem).
> >
> > *Most* of the changes since the release are on the head;  *some* of the
> > changes on the CMF-1_3-branch look inappropriate (e.g., there is a 
> > bunch
> > of new features added to CMFEvent), while others (the 
> > race-condition fix
> > for FSObject/FSDTMLMethod) are proper.
> >
> > The 'changeSkin' change is iffy for the 1.3 branch:  it is a "new
> > feature", really.  The general rule is that new features go only on the
> > head, while bugfixes are done first on the current release branch and
> > then forward-ported to the head.
> 
> In one way you are right, the changeSkin is new functionality. 
> However, if the new functionality is the fix for the issue in 
> collector -
> 
> http://collector.zope.org/CMF/27
> 
> It might then be considered a bug fix right? If not then the bug is 
> still out standing, and fixing it will mean that there are two 
> methods for performing the same task.

That collector issue is interesting:  it reports as a bug breakage which
resulted from the modification of what was at best an undocumented API
(in reality, an accidental side effect);  the fix was to create a new,
documented API.

Tres.
-- 
===============================================================
Tres Seaver                                tseaver@zope.com
Zope Corporation      "Zope Dealers"       http://www.zope.com