[Zope-CMF] Re: [CMF-checkins] CVS: CMF/CMFCore - CatalogTool.py:1.30.4.7

[Shane Hathaway]

Chris Withers wrote:
> Hi Sidnei,
> 
> I'm probably missing something, but where are the tests to accompany 
> these checkins?

Not only that, but I don't feel good about that change.  It mixes the 
concept of "executable owner" and the "owner role".  The former 
shouldn't really be called ownership.  At ZC we've been planning to 
rename the concept.  It's more like a "code signature" or something.

Shane

> Sidnei da Silva wrote:
> 
>> Update of /cvs-repository/CMF/CMFCore
>> In directory cvs.zope.org:/tmp/cvs-serv2038/CMFCore
>>
>> Modified Files:
>>       Tag: CMF-1_3-branch
>>     CatalogTool.py Log Message:
>> Owner was not being added to allowedRolesAndUsers
>>
>> === CMF/CMFCore/CatalogTool.py 1.30.4.6 => 1.30.4.7 ===
>> --- CMF/CMFCore/CatalogTool.py:1.30.4.6    Thu Aug  1 15:07:55 2002
>> +++ CMF/CMFCore/CatalogTool.py    Thu Apr 24 17:25:23 2003
>> @@ -61,6 +61,10 @@
>>                  if allowed.has_key(role):
>>                      allowed['user:' + user] = 1
>>          if allowed.has_key('Owner'):
>> +            owner = ob.getOwner()
>> +            if hasattr( owner, 'getId' ):
>> +                if owner.getId() is not None:
>> +                    allowed['user:' + owner.getId()] = 1
>>              del allowed['Owner']
>>          return list(allowed.keys())
> 
> 
> 
> _______________________________________________
> Zope-CMF maillist  -  Zope-CMF@zope.org
> http://mail.zope.org/mailman/listinfo/zope-cmf
> 
> See http://collector.zope.org/CMF for bug reports and feature requests
>