[Zope-CMF] Re: [CMF-checkins] CVS: CMF/CMFDefault - SyndicationTool.py:1.21

Yuppie schubbe at web.de
Tue Dec 23 17:55:41 EST 2003


Tres Seaver wrote:
> I have a feeling that we are patching code here which would be better
> removed;  in particular, I can't see any reason to declare the
> 'editSynProperies' method public, and then turn around and do an
> unconditional permission check + raise Unauthorized as the first action
> of the method.

Well. It checks the permission for the object, not the tool.

> I would prefer to check in the attached patch (for 1.3 / 1.4;  the head
> needs some light sanding after applying it), which just delcares the
> method protected by the same permission used in the '_checkPermission'
> call;  it then rips out all the other cruft.
> Any issues with that?

Don't know if we need local permissions.


More information about the Zope-CMF mailing list