[Zope-CMF] Re: CachingPolicyManager improvements

[Tres Seaver]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Florent Guillaume wrote:
> How about just moving PortalTestCase to CMFCore/tests/whatever ?

CMFCore/tests/base/testcase.py would seem appropriate, with the concrete
version that actually instantiates a portal in
CMFDefault/tests/<somenmame> ;)

Note that the goal with unit tests is to use the *smallest possible
fixture*;  using PortalTestCase when you could equally well use
RequestTest reduces the usefulness of the test:

  - it runs slower (the "nibbled to death by ducks" effect, particularly
    when re-running the tests frequently, as we all should).

  - it may mask undesirable dependencies (CMFCore is not supposed to
    depend on CMFDefault, for instance, even in testing).

  - it *may* make the tests themselves obscure, because the actual
    behavior being tested is tied up in lots of "extraneous"
    bookkeeping.

I saw the last two of these effects today while fixing collector #381,
for instance.


Tres.
- --
===================================================================
Tres Seaver          +1 202-558-7113          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDIaCu+gerLs4ltQ4RAtEFAJ0TbsGOV7lKJg6/1IvSP16xTzI8XwCdG5Ch
ahdkNhM20qYzpGfp31RlTLE=
=FvNy
-----END PGP SIGNATURE-----