[Zope-dev] Re: [Zope-Checkins] CVS: Zope/lib/python/TAL - TALInterpreter.py:1.69.6.10

[Florent Guillaume]

But why? Why escape double quotes when it's not a reserved character?
I really don't understand the need, and the example in the collector
doesn't convince me. What is the problem?

Escaping quotes is needed in double quotes-delimited attributes but not
elsewhere.

Florent


On Mon, 2002-12-23 at 01:49, Andy McKay wrote:
> Collector number 735: http://collector.zope.org/Zope/735
> 
> This was prompted by some bugs people found with Plone. For a two character
> fix that to me looked like a simple oversight I didn't bother with a unit
> test.
> --
>   Andy McKay
> 
> ----- Original Message -----
> From: "Florent Guillaume" <fg@nuxeo.com>
> To: <andy@agmweb.ca>
> Cc: <zope-dev@zope.org>
> Sent: Sunday, December 22, 2002 11:01 AM
> Subject: [Zope-dev] Re: [Zope-Checkins] CVS: Zope/lib/python/TAL -
> TALInterpreter.py:1.69.6.10
> 
> 
> > What prompted this? What does it fix?
> > I don't see that quotes need escaping here.
> > Also, there should be a unit test for it.
> > (And if it's a fix it should be in HEAD too.)
> >
> > Florent
> >
> > In article <200212180033.gBI0Xh515285@cvs.baymountain.com> you write:
> > > Modified Files:
> > >       Tag: Zope-2_6-branch
> > > TALInterpreter.py
> > > Log Message:
> > > Escape quotes correctly
> > >
> > >
> > > === Zope/lib/python/TAL/TALInterpreter.py 1.69.6.9 => 1.69.6.10 ===
> > > --- Zope/lib/python/TAL/TALInterpreter.py:1.69.6.9 Wed Oct  9 10:37:38
> 2002
> > > +++ Zope/lib/python/TAL/TALInterpreter.py Tue Dec 17 19:33:43 2002
> > > @@ -486,7 +486,7 @@
> > >          if text is self.Default:
> > >              self.interpret(stuff[1])
> > >              return
> > > -        s = escape(text)
> > > +        s = escape(text, 1)
> > >          self._stream_write(s)
> > >          i = s.rfind('\n')
> > >          if i < 0:
> >
> >
> > --
> > Florent Guillaume, Nuxeo (Paris, France)
> > +33 1 40 33 79 87  http://nuxeo.com  mailto:fg@nuxeo.com
> >
> > _______________________________________________
> > Zope-Dev maillist  -  Zope-Dev@zope.org
> > http://lists.zope.org/mailman/listinfo/zope-dev
> > **  No cross posts or HTML encoding!  **
> > (Related lists -
> >  http://lists.zope.org/mailman/listinfo/zope-announce
> >  http://lists.zope.org/mailman/listinfo/zope )
> 
-- 
Florent Guillaume, Nuxeo (Paris, France)
+33 1 40 33 79 87  http://nuxeo.com  mailto:fg@nuxeo.com