[Zope-dev] Bare except and ConflictError in manage_beforeDelete

Sidnei da Silva sidnei at awkly.org
Fri Oct 31 06:50:24 EST 2003


On Fri, Oct 31, 2003 at 12:28:45PM +0100, Florent Guillaume wrote:
| I have code that needs to maintain certain invariants when objects are 
| deleted, these invariants are maintained in manage_beforeDelete.
| 
| Unfortunately manage_beforeDelete has this code:
|             try:
|                 if hasattr(aq_base(object), 'manage_beforeDelete'):
|                     object.manage_beforeDelete(item, container)
|             except BeforeDeleteException, ob:
|                 raise
|             except:
|                 LOG('Zope',ERROR,'manage_beforeDelete() threw',
|                     error=sys.exc_info())
|                 pass
| Which means that ConflictErrors in my invariant code get swallowed, and 
| my invariants are broken. This kills me.
| 
| I want to add an additionnal:
|             except ConflictError:
|                 raise

+1 from me.

-- 
Sidnei da Silva <sidnei at awkly.org>
dreamcatching :: making your dreams come true
http://awkly.org

My apologies if I sound angry.  I feel like I'm talking to a void.
	-- Avery Pennarun



More information about the Zope-Dev mailing list