[Zope-dev] Re: SVN: Zope/branches/2.10/lib/python/Products/PageTemplates/Expressions.py Revert unwanted checkin.

Tres Seaver tseaver at palladion.com
Thu Jun 1 14:15:29 EDT 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Florent Guillaume wrote:
> Log message for revision 68445:
>   Revert unwanted checkin.
>   
> 
> Changed:
>   U   Zope/branches/2.10/lib/python/Products/PageTemplates/Expressions.py
> 
> -=-
> Modified: Zope/branches/2.10/lib/python/Products/PageTemplates/Expressions.py
> ===================================================================
> --- Zope/branches/2.10/lib/python/Products/PageTemplates/Expressions.py	2006-06-01 14:44:13 UTC (rev 68444)
> +++ Zope/branches/2.10/lib/python/Products/PageTemplates/Expressions.py	2006-06-01 14:46:17 UTC (rev 68445)
> @@ -99,8 +99,6 @@
>  class ZopePathExpr(PathExpr):
>  
>      def __init__(self, name, expr, engine):
> -        if name == 'standard' and not expr:
> -            expr = 'nothing'
>          super(ZopePathExpr, self).__init__(name, expr, engine,
>                                             boboAwareZopeTraverse)

Why revert?  I was fine with this, rather than my warning-emitting
version.  Go ahead and forward-port it to the trunk, and close out the
collector issue with a note saying "Zope2 allows empty path expressions"
(maybe reference the issue in the code?)


Tres.
- --
===================================================================
Tres Seaver          +1 202-558-7113          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEfy7B+gerLs4ltQ4RApyTAKCmDBSKHNAuG3eTUH1Z/tLH59fKDQCgzT8X
paaBvzwGUbuOhP5bB2kuRoA=
=mIGe
-----END PGP SIGNATURE-----



More information about the Zope-Dev mailing list