[Zope-dev] Sorting for zope.index

Dan Korostelev nadako at gmail.com
Sun Dec 28 09:57:52 EST 2008


2008/12/28 Chris McDonough <chrism at plope.com>:

> IMO, the cognitive cost of maintaining the write-on-read and
> by-default-normalize code (imagine someone looking at this code three years from
> now) is pretty high.  For example, it took me about two or three hours to figure
> out that the keyword index case normalization code was added by someone who
> didn't really understand what the kw index was actually used for; I thought I
> was just missing something.  I'm not sure what I'd think if I came across the
> write-on-read code; it'll be there forever if we don't take it out now.

> Given that we *know* that the kw index and topic index filtered set can't have
> been used except for anything but very special-purpose things (they could have
> only been used outside the catalog), I think it'd be fine to tell the folks who
> used them to how do the one-time upgrade in CHANGES.txt.  IMO, of course.

I'm generally fine with that. So if there won't be objections until
tommorow, I'll make that refactorings and merge that code to trunk.

-- 
WBR, Dan Korostelev


More information about the Zope-Dev mailing list