[Zope-dev] z3c.form vs. Invalid exceptions

Christian Theune ct at gocept.com
Fri Feb 26 10:38:16 EST 2010


On 02/26/2010 04:23 PM, Martin Aspeli wrote:
> Stephan Richter wrote:
>> On Friday 26 February 2010, Martin Aspeli wrote:
>>> The z3c.form doctests make it look like raising zope.interface.Invalid()
>>> would be an acceptable thing for a validator to do. It also makes it
>>> look like the argument passed to the Invalid() constructor is a string
>>> that would be displayed as an error message.
>>
>> After reviewing the code and comments briefly, I think this is a bug. I am
>> amazed that it has not surfaced before. I guess Invalid from zope.interface is
>> simply not raised that often.
>>
>> Feel free to fix the bug with a test. You can also release a new z3c.form
>> version if you like. I can give you access
> 
> Fixed.
> 
> I also added the behaviour to not render anything for a non-200 request.

Yay!


-- 
Christian Theune · ct at gocept.com
gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany
http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1
Zope and Plone consulting and development



More information about the Zope-Dev mailing list