[Zope-dev] zope-tests - FAILED: 17, OK: 91

[Gediminas Paulauskas]

2011/5/25 Marius Gedminas <marius at gedmin.as>:
> On Wed, May 25, 2011 at 09:18:46AM -0400, Tres Seaver wrote:
>> > [3]    FAILED  Zope Buildbot / zopetoolkit-1.0-py2.5 slave-osx
>> >        https://mail.zope.org/pipermail/zope-tests/2011-May/041867.html
>>
>> The is an FTP test failure, similar to others which have showed up::
>>
>> -------------------------- $< -------------------------
>> Failure in test testHELP (zope.server.ftp.tests.test_ftpserver.Tests)
>> Traceback (most recent call last):
>>   File
>> "/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/unittest.py",
>> line 260, in run
>>     testMethod()
>>   File
>> "/Users/buildslave/.buildout/eggs/zope.server-3.6.2-py2.5.egg/zope/server/ftp/tests/test_ftpserver.py",
>> line 278, in testHELP
>>     self.assertEqual(self.execute('HELP', 1), result)
>>   File
>> "/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/unittest.py",
>> line 334, in failUnlessEqual
>>     (msg or '%r != %r' % (first, second))
>> AssertionError: '214-The following commands are recognized\r\n' !=
>> '214-The following commands are recognized\r\nHelp goes here
>> somewhen.\r\n214 Help done.\r\n'
>> -------------------------- $< -------------------------
>>
>> I have no idea why this failure is only occasionaly, and only on OS/X.
>
> I had a theory and proposed a possible fix a while ago, but had no way
> of testing it:
> https://mail.zope.org/pipermail/zope-dev/2010-December/042138.html

I have tested this and committed an equivalent patch:

http://zope3.pov.lt/trac/changeset/121089/zope.server/trunk

This was released recently as zope.server 3.8.3 (that has a new test
failing on Python < 2.6)

Have to backport to 3.6 branch for ZTK 1.0... and make new bugfix release

-- 
Gediminas