[Zope-PAS] Re: challenge branch ready for review
zbir at urbanape.com
Wed Oct 13 21:37:42 EDT 2004
On 2004-10-13 21:31:55 -0400, "Mark Hammond"
<mhammond at skippinet.com.au> said:
>> - the new challenge machinery discussed here that limits players in
>> a given challenge to plugins that support the same protocol
> I'm having a little trouble making this work with my plugin. The problem is
> that the HTTPBasicAuthHelper does not declare a protocol - so the
> HTTPBasicAuthHelper ID is used. My plugin wants to interact with
> HTTPBasicAuthHelper, but has no way of determining the protocol it should
> use to match HTTPBasicAuthHelper.
You're right, of course, I didn't specify the protocol on
HTTPBasicAuthHelper plugin. I'll go ahead and commit this to the branch.
> Is the intention to declare HTTPBasicAuthHelper as using a 'http' protocol?
Yes, we want the included plugins to be both "proof-of-concept" and a
stable and complete base off which to develop co-operative or competing
> The patch below declares this protocol for HTTPAuth, and replaces
> 'setHeader' with 'addHeader' (necessary for correct header semantics). With
> that patch applied, my plugin seems to work fine with HTTPAuth.
> I believe it is still a minor issue that plugins sharing a protocol have no
> way of knowing their order. This means HTTPAuth unconditionally sets the
> body and all other plugins sharing a protocol must do the same. Its not a
> show-stopper though.
I don't believe plugins should have any concept at all about their
order. That's up to the site manager. I think if it's vital (or even
important ;^)) that your plugin come at the beginning or the end,
document it loudly so that a site manager knows.
More information about the Zope-PAS