[Zope3-checkins] CVS: Zope3/lib/python/Zope/App/OFS/Container - ContainerTraverser.py:1.4.6.1

R. David Murray bitz@bitdance.com
Mon, 4 Nov 2002 10:39:52 -0500 (EST)


On Fri, 1 Nov 2002, Deb wrote:
> Log Message:
> modified to support introspector
[...]
>      def publishTraverse(self, request, name):
> -        c = self.context
> -
> -        subob = c.get(name, None)
> +        c = self.context
> +        subob = None
> +        try:
> +            subob = c.get(name, None)
> +        except:
> +            pass
>          if subob is None:
>

Um, a bare except?  I thought we were very much against bare excepts.
I'm not familiar with the introspector, but it seems dangerous to
me to mask errors we might want to know about when not doing
introspection in order to support introspection.  Of course,
there may be a very good reason for this, I'm just suspicious
on general principle <grin>.

--RDM