[Zope3-checkins] SVN: Zope3/trunk/src/zope/app/session/ Made one XXX a statement and another a TODO.

Stephan Richter srichter at cosmos.phy.tufts.edu
Thu Jul 8 18:31:27 EDT 2004


Log message for revision 26253:
Made one XXX a statement and another a TODO.



-=-
Modified: Zope3/trunk/src/zope/app/session/__init__.py
===================================================================
--- Zope3/trunk/src/zope/app/session/__init__.py	2004-07-08 22:30:23 UTC (rev 26252)
+++ Zope3/trunk/src/zope/app/session/__init__.py	2004-07-08 22:31:26 UTC (rev 26253)
@@ -99,14 +99,14 @@
 
     def setRequestId(self, request, id):
         """Set cookie with id on request."""
-        # XXX Currently, the path is the ApplicationURL. This is reasonable,
-        #     and will be adequate for most purposes.
-        #     A better path to use would be that of the folder that contains
-        #     the service-manager this service is registered within. However,
-        #     that would be expensive to look up on each request, and would
-        #     have to be altered to take virtual hosting into account.
-        #     Seeing as this service instance has a unique namespace for its
-        #     cookie, using ApplicationURL shouldn't be a problem.
+        # Currently, the path is the ApplicationURL. This is reasonable, and
+        # will be adequate for most purposes.
+        # TODO: A better path to use would be that of the folder that contains
+        # the service-manager this service is registered within. However, that
+        # would be expensive to look up on each request, and would have to be
+        # altered to take virtual hosting into account.  Seeing as this
+        # service instance has a unique namespace for its cookie, using
+        # ApplicationURL shouldn't be a problem.
 
         if self.cookieLifetime is not None:
             if self.cookieLifetime:
@@ -219,7 +219,6 @@
         try:
             sdc = getUtility(ISessionDataContainer, product_id)
         except ComponentLookupError:
-            # XXX: Do we want this?
             warnings.warn(
                     'Unable to find ISessionDataContainer named %s. '
                     'Using default' % repr(product_id),

Modified: Zope3/trunk/src/zope/app/session/interfaces.py
===================================================================
--- Zope3/trunk/src/zope/app/session/interfaces.py	2004-07-08 22:30:23 UTC (rev 26252)
+++ Zope3/trunk/src/zope/app/session/interfaces.py	2004-07-08 22:31:26 UTC (rev 26253)
@@ -39,7 +39,7 @@
         """
 
 
-    """ XXX: Want this
+    """ TODO: Want this:
     def invalidate(browser_id):
         ''' Expire the browser_id, and remove any matching ISessionData data 
         '''



More information about the Zope3-Checkins mailing list