[Zope3-checkins] SVN: Zope3/trunk/src/z3checkins/ Removed/downgraded all XXXs in z3checkins.

Gintautas Miliauskas gintas at pov.lt
Fri Mar 11 08:24:57 EST 2005


Log message for revision 29439:
  Removed/downgraded all XXXs in z3checkins.
  
  I have removed XXXes in test messages too, just so that they don't get in
  the way.
  

Changed:
  U   Zope3/trunk/src/z3checkins/browser.py
  U   Zope3/trunk/src/z3checkins/message.py
  U   Zope3/trunk/src/z3checkins/tests/mbox.txt
  U   Zope3/trunk/src/z3checkins/tests/mbox_with_dupes.txt
  U   Zope3/trunk/src/z3checkins/tests/svn_msg4.txt

-=-
Modified: Zope3/trunk/src/z3checkins/browser.py
===================================================================
--- Zope3/trunk/src/z3checkins/browser.py	2005-03-11 04:45:45 UTC (rev 29438)
+++ Zope3/trunk/src/z3checkins/browser.py	2005-03-11 13:24:56 UTC (rev 29439)
@@ -33,7 +33,7 @@
     data_widget = CustomWidgetFactory(FileWidget)
 
     def createAndAdd(self, data):
-        if data.has_key('data'): # XXX should we bark if no data is given?
+        if data.has_key('data'): # TODO should we bark if no data is given?
             msg_raw = data['data']
             parser = zapi.getUtility(IMessageParser)
             if msg_raw.startswith("From "):
@@ -300,7 +300,7 @@
 
     def body(self):
         """Colorize checkin message body."""
-        # XXX This method is rather bloated and hard to understand.
+        # TODO This method is rather bloated and hard to understand.
         text = self.context.body.replace('\r', '') \
                                 .replace('&', '&') \
                                 .replace('<', '&lt;') \
@@ -322,7 +322,7 @@
                 log_idx += len('\nLog:\n')
             else:
                 log_idx = text.find('Log message')
-                # XXX: Specific to Zope3 checkins
+                # This section is specific to Zope3 checkins
                 if log_idx != -1:
                     log_idx = text.find('\n', log_idx) + 1
         if log_idx == -1:

Modified: Zope3/trunk/src/z3checkins/message.py
===================================================================
--- Zope3/trunk/src/z3checkins/message.py	2005-03-11 04:45:45 UTC (rev 29438)
+++ Zope3/trunk/src/z3checkins/message.py	2005-03-11 13:24:56 UTC (rev 29439)
@@ -167,7 +167,7 @@
             subject = parts[1]
             directory = subject.split(' - ')[0]
         elif "SVN:" in subject:
-            # XXX: Format specific to the Zope3 mailing list
+            # Format that is specific to the Zope3 mailing list
             # [foo-bar] SVN: foobaz/boo/bar.py log message
             parts = subject.split("SVN: ", 1)
             if len(parts) < 2:

Modified: Zope3/trunk/src/z3checkins/tests/mbox.txt
===================================================================
--- Zope3/trunk/src/z3checkins/tests/mbox.txt	2005-03-11 04:45:45 UTC (rev 29438)
+++ Zope3/trunk/src/z3checkins/tests/mbox.txt	2005-03-11 13:24:56 UTC (rev 29439)
@@ -142,7 +142,7 @@
          if (set == NULL)
              goto Error;
  
--        /* XXX TODO: If set is a bucket, do a straight resize+memcpy instead.
+-        /* TODO: If set is a bucket, do a straight resize+memcpy instead.
 -        */
 -        if (initSetIteration(&setiter, set, 1, &merge) < 0)
 -            goto Error;

Modified: Zope3/trunk/src/z3checkins/tests/mbox_with_dupes.txt
===================================================================
--- Zope3/trunk/src/z3checkins/tests/mbox_with_dupes.txt	2005-03-11 04:45:45 UTC (rev 29438)
+++ Zope3/trunk/src/z3checkins/tests/mbox_with_dupes.txt	2005-03-11 13:24:56 UTC (rev 29439)
@@ -142,7 +142,7 @@
          if (set == NULL)
              goto Error;
  
--        /* XXX TODO: If set is a bucket, do a straight resize+memcpy instead.
+-        /* TODO: If set is a bucket, do a straight resize+memcpy instead.
 -        */
 -        if (initSetIteration(&setiter, set, 1, &merge) < 0)
 -            goto Error;

Modified: Zope3/trunk/src/z3checkins/tests/svn_msg4.txt
===================================================================
--- Zope3/trunk/src/z3checkins/tests/svn_msg4.txt	2005-03-11 04:45:45 UTC (rev 29438)
+++ Zope3/trunk/src/z3checkins/tests/svn_msg4.txt	2005-03-11 13:24:56 UTC (rev 29439)
@@ -24,7 +24,7 @@
 -        It is not the respoonsibility of the handler to wrap the return value.
 +        It is not the responsibility of the handler to wrap the return value.
 +
-+        XXX is this "wrap" comment still relevant?
++        TODO is this "wrap" comment still relevant?
          """
 
  class IPhysicallyLocatable(Interface):



More information about the Zope3-Checkins mailing list