[Zope3-checkins] [Checkins] SVN: zope.testing/trunk/ - fix test failure on Python 2.4 because of slight difference in the way

[Benji York]

On Mon, Apr 20, 2009 at 9:09 AM, Christian Theune <ct at gocept.com> wrote:
> On Mon, 2009-04-20 at 08:59 -0400, Benji York wrote:
>> On Fri, Apr 17, 2009 at 6:44 PM, Christian Theune <ct at gocept.com> wrote:
>> > On Mon, 2009-04-13 at 11:43 -0400, Benji York wrote:
>> >> Log message for revision 99151:
>> >>   - fix test failure on Python 2.4 because of slight difference in the way
>> >>     coverage is reported (__init__ files with only a single comment line are now
>> >>     not reported)
>> >>   - fixed bug that caused the test runner to hang when running subprocesses (as a
>> >>     result Python 2.3 is no longer supported).
>> >
>> > Ah, great. I was working towards a fix as well, but hadn't had time to
>> > fix that. For me this only appeared on 2.5, not 2.4, same for you?
>>
>> It happened with 2.6 for me.  I believe the cause was deprecation
>> warnings confusing the (rather brittle) stderr parsing.
>>
>> > Something that I also see: the output of subprocesses is only displayed
>> > after the subprocess finished which also gives the impression of hangs
>> > also it just takes time.
>>
>> Yep, that was a side-effect of changing the subprocess output parsing
>> from "online" to "offline".
>
> Ok, so I guess you wouldn't mind if I brought it back? :)

As long as the result is as stable as the status quo, it's fine with me.
-- 
Benji York
Senior Software Engineer
Zope Corporation